Thread (61 messages) 61 messages, 20 authors, 2013-05-31

[PATCH 03/21] ARM: shmobile: don't call irqchip_init unconditionally

From: Bastian Hecht <hidden>
Date: 2013-05-08 13:22:25
Also in: lkml

Hi,

2013/5/8 Arnd Bergmann [off-list ref]:
On Thursday 02 May 2013, Simon Horman wrote:
quoted
quoted
quoted
diff --git a/arch/arm/mach-shmobile/intc-r8a7740.c b/arch/arm/mach-shmobile/intc-r8a7740.c
index 8871f77..5dc57f1 100644
--- a/arch/arm/mach-shmobile/intc-r8a7740.c
+++ b/arch/arm/mach-shmobile/intc-r8a7740.c
@@ -53,14 +53,23 @@ static void __init r8a7740_init_irq_common(void)

 void __init r8a7740_init_irq_of(void)
 {
+       if (!IS_ENABLED(CONFIG_OF))
+               return;
+
        irqchip_init();
Why not have an empty irqchip_init? I'd guess we'll need this on other
platforms and your default mach.
Thanks, I think that could work.

I will see about making it so.
Ping
I have sent out a patch adding an empty irqchip_init() when
CONFIG_IRQCHIP is not set with the subject
[PATCH] irqchip: Add irqchip_init dummy function
Linux-next is still broken for me. There is also anothe shmobile build bug,
I'll send a separate patch for that, which also needs to go into your tree.
Oh thanks Arnd for this fix!

Cheers,

 Bastian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help