[PATCH 02/16] pinctrl: exynos: Parse wakeup-eint parameters from DT

On Wednesday 10 of October 2012 09:18:51 Linus Walleij wrote:

On Mon, Oct 8, 2012 at 10:39 AM, Tomasz Figa [off-list ref] wrote:

quoted

This patch converts the pinctrl-exynos driver to parse wakeup interrupt
count and register offsets from device tree. It reduces the amount of
static platform-specific data and facilitates adding further SoC
variants to pinctrl-samsung driver.

So these are:

quoted

+       ret = of_property_read_u32(wkup_np, "samsung,weint-count",
&val); +       ret = of_property_read_u32(wkup_np,
"samsung,weint-con", &val); +       ret =
of_property_read_u32(wkup_np, "samsung,weint-mask", &val); +       ret
= of_property_read_u32(wkup_np, "samsung,weint-pend", &val);

Are these all four register offsets?

I don't think it's proper for the device tree to contain register
offsets.

Base address, "regs" property, yes. Individual registers, no. That just
makes the code hard to read and compare to the datasheet.

Or what are you aiming at here?

See my reply to your comments for patch 1. I think it should explain how 
these values are used.

One thing worth mentioning is that registers for GPIO interrupts and wakeup 
interrupts can be located at different areas of pin controller address 
space, so these offsets have to be specified for both (using geint-* and 
weint-* properties).

Best regards,
-- 
Tomasz Figa
Samsung Poland R&D Center