Thread (39 messages) flat view 39 messages, 5 authors, 2012-10-11

[PATCH 03/16] pinctrl: samsung: Detect and handle unsupported configuration types

From: Linus Walleij <hidden>
Date: 2012-10-10 07:37:42
Also in: linux-devicetree, linux-samsung-soc

On Mon, Oct 8, 2012 at 10:39 AM, Tomasz Figa [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch modifies the pinctrl-samsung driver to detect when width of a
bit field is set to zero (which means that such configuraton type is not
supported) and return an error instead of trying to modify an inexistent
register.

Signed-off-by: Tomasz Figa <redacted>
---
 drivers/pinctrl/pinctrl-samsung.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
index dd108a9..c660fa5 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -391,6 +391,9 @@ static int samsung_pinconf_rw(struct pinctrl_dev *pctldev, unsigned int pin,
                return -EINVAL;
        }

+       if (!width)
+               return -EINVAL;
+
Can this patch be applied in isolation from the others?
Thomas A: can you ACK this so I can apply it in that case?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help