Thread (39 messages) flat view 39 messages, 5 authors, 2012-10-11

[PATCH 11/16] pinctrl: samsung: Use one GPIO chip per pin bank

From: Linus Walleij <hidden>
Date: 2012-10-10 07:43:25
Also in: linux-devicetree, linux-samsung-soc

On Mon, Oct 8, 2012 at 10:39 AM, Tomasz Figa [off-list ref] wrote:
This patch modifies the pinctrl-samsung driver to register one GPIO chip
per pin bank, instead of a single chip for all pin banks of the
controller.

It simplifies GPIO accesses a lot (constant time instead of looping
through the list of banks to find the right one) and should have a good
effect on performance of any bit-banging driver.

In addition it allows to reference GPIO pins by a phandle to the bank
node and a local pin offset inside of the bank (similar to previous
gpiolib driver), which is more clear and readable than using indices
relative to the whole pin controller.

Example:
        device {
                /* ... */
                gpios = <&gpk0 4 0>;
                /* ... */
        };

Signed-off-by: Tomasz Figa <redacted>
This also looks good (and I think it has been discussed before)
so needs to be applied in isolation from the regs-to-DT stuff.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help