Thread (32 messages) 32 messages, 13 authors, 2012-10-22

[PATCH 03/12] mmc: dw_mmc: fix building exynos driver as a module

From: Seungwon Jeon <hidden>
Date: 2012-10-04 12:41:04
Also in: linux-mmc, lkml

Monday, October 01, 2012, Will Newton [off-list ref] wrote:
On Fri, Sep 28, 2012 at 10:36 PM, Arnd Bergmann [off-list ref] wrote:
quoted
The MODULE_DEVICE_TABLE() entry in the dw_mmc_exynos driver
points to the wrong symbol which results in a link error
when building as a loadable module.

Further, we get a warning about the driver_data being
marked constant, which requires annotating a few pointers
as const.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Chris Ball <redacted>
Cc: Thomas Abraham <redacted>
Cc: Will Newton <redacted>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Seungwon Jeon <redacted>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-mmc at vger.kernel.org
---
 drivers/mmc/host/dw_mmc-exynos.c |    4 ++--
 drivers/mmc/host/dw_mmc-pltfm.c  |    2 +-
 drivers/mmc/host/dw_mmc-pltfm.h  |    2 +-
 drivers/mmc/host/dw_mmc.c        |    2 +-
 include/linux/mmc/dw_mmc.h       |    2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)
This looks ok to me, but I'll let one of the Exynos guys ack those
specific changes as I don't have the hardware.

There's already a patch for the dev_info warning in dw_mmc.c frm
Seungwon Jeon, and it seems to me like a separate change but I don't
really mind how it gets merged.
Looks good to me.
I don't mind it about including 'dev_info warning'.

Acked-by: Seungwon Jeon<redacted>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help