Thread (32 messages) 32 messages, 13 authors, 2012-10-22

[PATCH 02/12] ata: mark probe function as __devinit rather than __init

From: Mark Langsdorf <hidden>
Date: 2012-09-28 21:38:03
Also in: lkml

On 09/28/2012 04:36 PM, Arnd Bergmann wrote:
quoted hunk ↗ jump to hunk
Functions for hotplugging must be marked as __devinit so
they do not get discarded, as pointed out by a build time
warning from modpost.

Cc: Mark Langsdorf <redacted>
Cc: Rob Herring <redacted>
Cc: Jeff Garzik <redacted>
---
 drivers/ata/sata_highbank.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
index 0d7c4c2..36a141a 100644
--- a/drivers/ata/sata_highbank.c
+++ b/drivers/ata/sata_highbank.c
@@ -260,7 +260,7 @@ static const struct of_device_id ahci_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, ahci_of_match);
 
-static int __init ahci_highbank_probe(struct platform_device *pdev)
+static int __devinit ahci_highbank_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct ahci_host_priv *hpriv;
Thanks. I just ran into this today and couldn't figure out the error
message.

Acked-by: Mark Langsdorf <redacted>

--Mark Langsdorf
Calxeda, Inc.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help