Thread (32 messages) 32 messages, 13 authors, 2012-10-22

[PATCH 11/12] pinctrl: samsung: use __devinit section for init code

From: Linus Walleij <hidden>
Date: 2012-10-01 06:15:05
Also in: lkml

On Fri, Sep 28, 2012 at 11:36 PM, Arnd Bergmann [off-list ref] wrote:
The samsung pinctrl driver has a probe function that is
__devinit and that calls a lot of other functions that are
marked __init, which kbuild complains about.

Marking everything __devinit means that the code does not
discarded when CONFIG_HOTPLUG is set, which is a little
more wasteful, but also more consistent

Without this patch, building exynos_defconfig results in:

WARNING: drivers/pinctrl/built-in.o(.devinit.text+0x124): Section mismatch in reference from the function samsung_pinctrl_probe() to the function .init.text:samsung_gpiolib_register()
The function __devinit samsung_pinctrl_probe() references
a function __init samsung_gpiolib_register().
If samsung_gpiolib_register is only used by samsung_pinctrl_probe then
annotate samsung_gpiolib_register with a matching annotation.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Abraham <redacted>
Cc: Linus Walleij <redacted>
Cc: Stephen Warren <redacted>
Cc: Kukjin Kim <redacted>
Acked-by: Linus Walleij <redacted>

I think the Samsing pinctrl driver has landed into next from some
branch in ARM SoC so you probably know better than me
where this thing should be merged...

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help