[PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare
From: Pankaj Jangra <hidden>
Date: 2012-09-26 16:58:35
Also in:
linux-arm-msm, lkml
Hi.. On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add calls to clk_prepare and unprepare so that MSM can migrate to the common clock framework. Cc: Felipe Balbi <redacted> Signed-off-by: Stephen Boyd <redacted> --- drivers/usb/otg/msm_otg.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-)diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c index 9f5fc90..2ae0639 100644 --- a/drivers/usb/otg/msm_otg.c +++ b/drivers/usb/otg/msm_otg.c@@ -514,13 +514,13 @@ static int msm_otg_suspend(struct msm_otg *motg) motg->pdata->otg_control == OTG_PMIC_CONTROL) writel(readl(USB_PHY_CTRL) | PHY_RETEN, USB_PHY_CTRL); - clk_disable(motg->pclk); - clk_disable(motg->clk); + clk_disable_unprepare(motg->pclk); + clk_disable_unprepare(motg->clk); if (motg->core_clk) - clk_disable(motg->core_clk); + clk_disable_unprepare(motg->core_clk);
I was under assumption that system suspend/resume might be called from the interrupt context. If that is case then its not appropriate to call clk_prepare/unprepare here right? or my understanding is not correct???? -- Pankaj Jangra