Thread (21 messages) flat view 21 messages, 5 authors, 2013-12-09
STALE4626d

[PATCH 3/4 V2] ARM: mxs: Update DENX M28 machine and dts file

From: Marek Vasut <hidden>
Date: 2012-08-26 11:42:34

Dear Shawn Guo,
On Sat, Aug 25, 2012 at 01:51:39AM +0200, Marek Vasut wrote:
quoted
+
+		reg_vddio_sd0: vddio-sd0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio3 28 0>;
+		};
+
+		reg_usb0_vbus: usb0_vbus {
+			compatible = "regulator-fixed";
+			regulator-name = "usb0_vbus";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			gpio = <&gpio3 12 0>;
+			enable-active-low;
Documentation/devicetree/bindings/regulator/fixed-regulator.txt:

- enable-active-high: Polarity of GPIO is Active high
If this property is missing, the default assumed is Active low.

I suspect you need to recheck this aspect for all these 3 fixed
regulators.
Ok, so the prop had no impact? I'll retest and resubmit. Also, put the SPS1 on 
hold until the led issue is done for.

Thanks
quoted
+		};
+
+		reg_usb1_vbus: usb1_vbus {
+			compatible = "regulator-fixed";
+			regulator-name = "usb1_vbus";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			gpio = <&gpio3 13 0>;
+			enable-active-low;
+		};
Best regards,
Marek Vasut
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help