On Wed, Aug 01, 2012 at 03:50:12PM +0800, Shawn Guo wrote:

On Tue, Jul 31, 2012 at 11:56:50PM -0700, Guenter Roeck wrote:

quoted

Guess we are in violent agreement. The sequence would then either be
	master = spi_alloc_device();

The discussion is around spi_alloc_master rather than spi_alloc_device,
isn't it?

Yes, sorry. Too late at night, too tired :(.

Guenter

Regards,
Shawn

quoted

	...
	spi_master_put(master);
or
	master = spi_alloc_device();
	...
	kfree(master);

which makes sense to me. Question still is why most drivers neither call kfree()
nor spi_master_put() in the remove function.