On Wed, Aug 1, 2012 at 10:59 AM, Guenter Roeck [off-list ref] wrote:

On Wed, Aug 01, 2012 at 07:00:54AM +0200, Marek Vasut wrote:

quoted

Dear Shawn Guo,

quoted

On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote:

quoted

I think the call to spi_master_put() triggers the call to
spi_master_release(). If so, kfree() would not be needed at all, and the
documentation is wrong.

Also those drivers calling kfree in probe.

Looks like that to me ...

Doesn't seem to be far spread, fortunately. Only spi-davinci.c, spi-imx.c, and
spi-omap2-mcspi.c

I have a  omapsdp I could patch spi-omap2-mcspi.c  file thanks for the catch.

as far as I can see, plus the misleading comment in spi.c.

Anyone up for writing some patches ? If not, I'll do it.

Thanks,
Guenter

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
spi-devel-general mailing list
spi-devel-general at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general