Thread (43 messages) 43 messages, 7 authors, 2012-08-01

[06/10,V2] spi: Add SPI driver for mx233/mx28

From: Marek Vasut <hidden>
Date: 2012-08-01 06:41:34
Also in: linux-spi

Dear Guenter Roeck,
On Wed, Aug 01, 2012 at 11:16:15AM +0530, Shubhrajyoti Datta wrote:
quoted
On Wed, Aug 1, 2012 at 10:59 AM, Guenter Roeck [off-list ref] wrote:
quoted
On Wed, Aug 01, 2012 at 07:00:54AM +0200, Marek Vasut wrote:
quoted
Dear Shawn Guo,
quoted
On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote:
quoted
I think the call to spi_master_put() triggers the call to
spi_master_release(). If so, kfree() would not be needed at all,
and the documentation is wrong.
Also those drivers calling kfree in probe.
Looks like that to me ...
Doesn't seem to be far spread, fortunately. Only spi-davinci.c,
spi-imx.c, and spi-omap2-mcspi.c
I have a  omapsdp I could patch spi-omap2-mcspi.c  file thanks for the
catch.
For that it would be good to determine if there is a memory leak when
removing the driver (I don't see where the memory allocated with
spi_alloc_master is removed).
When the refcounting for the device reaches 0, it's deallocated. (Aka _put long 
enough and it'll disappear)
Thanks,
Guenter
Best regards,
Marek Vasut
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help