Thread (25 messages) flat view 25 messages, 8 authors, 2012-08-13

[PATCH 10/10] leds: renesas: fix error handling

From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-08-09 07:34:16
Also in: lkml

On Thursday 09 August 2012, Bryan Wu wrote:
On Thu, Aug 9, 2012 at 5:27 AM, Arnd Bergmann [off-list ref] wrote:
quoted
bfe4c041 "leds: convert Renesas TPU LED driver to devm_kzalloc() and
cleanup error exit path" introduced a possible case in which r_tpu_probe
calls iounmap on a wild pointer. This changes the one case that was
missed in the same way as the other error paths.

Without this patch, building kota2_defconfig results in:

drivers/leds/leds-renesas-tpu.c: In function 'r_tpu_probe':
drivers/leds/leds-renesas-tpu.c:246:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
drivers/leds/leds-renesas-tpu.c:308:17: warning: 'p' may be used uninitialized in this function [-Wuninitialized]
Thanks, Arnd. If you don't mind, I will apply this fixing through my led tree.
Ok, excellent. One less patch for me to worry about. Dropped from my tree now.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help