Thread (39 messages) 39 messages, 6 authors, 2012-07-31
STALE5175d

[PATCH] spi-orion: add device tree binding

From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-07-23 17:43:13

On Monday 23 July 2012, Mark Brown wrote:
On Mon, Jul 23, 2012 at 12:59:45PM +0200, Andrew Lunn wrote:
quoted
On Mon, Jul 23, 2012 at 11:43:34AM +0100, Mark Brown wrote:
quoted
On Mon, Jul 23, 2012 at 12:08:09PM +0200, Andrew Lunn wrote:
quoted
quoted
quoted
+Optional properties:
+- interrupts : Is currently not used.
quoted
quoted
Would it not be better to just omit this if it doesn't do anything and
doesn't have any semantics defined?
quoted
I was specifically asked to include this, which is why it appeared in
v2, not the first version. I forget who it was who asked for it, maybe
Arnd Bergmann? I can dig through my email archive if you want to know.
If you're going to include it you should define some sematics for it.
You could define an optional "yohNg1ai" property too...
Agreed. I'm rather sure I did not ask for an unused property to be
documented. However, the documentation should definitely match the
example and the what kinds of properties are used in the device tree.

If the device has an interrupt that is not used by Linux, I would
document what the interrupt is for.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help