Thread (39 messages) 39 messages, 6 authors, 2012-07-02
STALE5080d

[PATCH v2 2/2] net: flexcan: add transceiver switch gpios support

From: Shawn Guo <hidden>
Date: 2012-06-28 12:05:24
Also in: linux-can

On Thu, Jun 28, 2012 at 07:52:26PM +0800, Shawn Guo wrote:
Do you care the variable name also?  If so, we will get:

        int transceiver_en_gpio;
        int transceiver_stby_gpio;
        bool transceiver_en_high;
        bool transceiver_stby_high;

So everything becomes long :)
Oh, even longer, since we have agreed "high" should be renamed to
"active_low":

	bool transceiver_en_active_low;
	bool transceiver_stby_active_low;

Can we keep using "phy" to have the names a little bit shorter?

-- 
Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help