Shawn Guo wrote:

On Thu, Jun 28, 2012 at 02:14:39PM +0800, Hui Wang wrote:
  

quoted

quoted

diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
index 8ff324e..e0dbac7 100644
--- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
+++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt

@@ -15,6 +15,8 @@ Required properties:

Optional properties:
- clock-frequency : The oscillator frequency driving the flexcan device
+- phy-enable-gpios : Specify the gpio used to enable phy
+- phy-standby-gpios : Specify the gpio used to put phy into STANDBY mode
Example:
      

Do we need to add new added entries in the example section as well.

E.g.

+        phy-enable-gpios = <&gpio1 4 0>; /* GPIO1_4, active high*/
+        phy-standby-gpios = <&gpio1 2 1>; /* GPIO1_2, active low */

    

I chose not to because after all these two are optional properties.

  

OK.

quoted

quoted

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 38c0690..1ce3f9e 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c

@@ -26,6 +26,7 @@

#include <linux/can/platform/flexcan.h>
#include <linux/clk.h>
#include <linux/delay.h>
+#include <linux/gpio.h>
      

It seems <linux/of_gpio.h> already unconditionally includes this header.
    

Documentation/SubmitChecklist

1: If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.

  

Got it.

OK to me.

Regards,
Hui.