Dove clock support
From: andrew@lunn.ch (Andrew Lunn)
Date: 2012-06-19 19:32:51
On Tue, Jun 19, 2012 at 12:10:16AM +0200, Sebastian Hesselbarh wrote:
On 06/18/2012 11:41 PM, Simon Baatz wrote:quoted
This is not potentially a problem, this is definitively a problem (on kirkwood): [ 12.280783] sata_mv sata_mv.0: cannot get optional clkdev [ 12.286314] sata_mv sata_mv.0: slots 32 ports 2 ... [ 12.665882] ata1: SATA link down (SStatus 0 SControl F300) [ 13.015881] ata2: SATA link down (SStatus 0 SControl F300)Is this because of some bug in kirkwood soc or missing code in sata_mv.c? According to the functional specification of kirkwood there is a PhyShutdown bit in it's registers. Dove also has this register bit. Up to now it looks like the SATA PHY can only be disabled in code, but there should be an phy_enable, too.
Correct. When moving from kirkwoods old clock management to the generic clock framework, i kept the functionality the same. The old code would turn the PHYs off, but have no way to turn them back on again. The new code is the same. Andrew