Thread (27 messages) 27 messages, 3 authors, 2012-05-10
STALE5147d
Revisions (31)
  1. rfc [diff vs current]
  2. rfc [diff vs current]
  3. rfc [diff vs current]
  4. rfc [diff vs current]
  5. v2 [diff vs current]
  6. v2 [diff vs current]
  7. v3 [diff vs current]
  8. v2 [diff vs current]
  9. v3 [diff vs current]
  10. v3 [diff vs current]
  11. v3 [diff vs current]
  12. v4 [diff vs current]
  13. v4 [diff vs current]
  14. v4 [diff vs current]
  15. v4 [diff vs current]
  16. v4 [diff vs current]
  17. v5 [diff vs current]
  18. v5 [diff vs current]
  19. v5 [diff vs current]
  20. v6 [diff vs current]
  21. v6 [diff vs current]
  22. v7 [diff vs current]
  23. v7 [diff vs current]
  24. v7 [diff vs current]
  25. v7 [diff vs current]
  26. v7 current
  27. v7 [diff vs current]
  28. v7 [diff vs current]
  29. v7 [diff vs current]
  30. v7 [diff vs current]
  31. v8 [diff vs current]

[RFC PATCH 00/11 V7] MXS: Add i.MX28 USB Host driver

From: marex@denx.de (Marek Vasut)
Date: 2012-05-03 13:27:15

Dear Chen Peter-B29397,
quoted
Still use IRQF_SHARED for the usb interrupt, but:
* The IRQ handler in ehci-mxs, that's set in hc_driver.irq would be
always
returning IRQ_NONE.
* The IRQ handler in imx-otg would call the callback registered via
imx_otg_set_irq_handler() only if the port was actually in host mode
The interrupt which is registered by hcd core is usb_hcd_irq, it will call
ehci_irq. The hc_driver.irq is included in usb_hcd_irq.
Hm, that's correct. I'll dive in and see if there's any other way around. I 
think I saw IRQF_DISABLED somewhere there, but that might be just some phantom. 
Either way, is this direction I'm taking the correct one (have irq handler in 
imx-otg and send IRQs to gadget/host drivers from there)?

Also, any other comments about this patchset before I roll out another version?

Thanks!

Best regards,
Marek Vasut
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help