[RFC PATCH 00/11 V7] MXS: Add i.MX28 USB Host driver
From: marex@denx.de (Marek Vasut)
Date: 2012-05-01 03:49:34
Dear Chen Peter-B29397,
quoted
quoted
If the host and device interrupt handler are called by otg interrupt handler, then, the interrupt handlers are registered by host/devicewillquoted
be called twice as they are also registered by host/device themselves.No they won't, I don't register them in ehci-mxs or ci13xxx-mxs anymore.Have you changed any hcd code? The host interrupt is registered by hcd core code: usb_add_hcd.
I pass 0 as IRQ, thinking about it, that's not really correct (it's actually very lame mistake). Well, let's fix it in V8. I suggest we do a stub handler in the ehci-mxs for usb_add_hcd() and call ehci_irq() from the imx-otg's IRQ handler like it's already done in this patchset.
quoted
quoted
Besides, what kinds of function do you want to add at this patchset?Device and Host mode, separate so far, configurable by platform data. I'm also looking into the OTG, but let's get this basic stuff right and mainline first.Then, the aim for this patchset is only enable OTG port, and device/host function is selected by platform data, no otg function(id switch) will be supported, correct?
Correct. But this patchset also works with the host-only port #1 on mx28 (obviously, you can't enable gadget(device) mode for that port).
Understanding your scope may help me review your patches.quoted
Best regards, Marek Vasut
Best regards, Marek Vasut