Thread (43 messages) flat view 43 messages, 5 authors, 2012-02-20

[PATCH 16/18] Atmel: move console default platform_device to serial driver

From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2012-02-19 14:23:08
Also in: lkml

On 10:17 Sat 18 Feb     , Hans-Christian Egtvedt wrote:
Around Fri 17 Feb 2012 18:50:08 +0100 or thereabout, Nicolas Ferre wrote:
quoted
From: Jean-Christophe PLAGNIOL-VILLARD <redacted>

This variable spread on every SoC that is using the atmel_serial.c
driver can be included directly into the latter.

This will allow to compile multiple soc in the same kernel.
Sounds like a good idea, but...

<snipp AT91 changes>
quoted
diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c
index 402a7bb..889c544 100644
--- a/arch/avr32/mach-at32ap/at32ap700x.c
+++ b/arch/avr32/mach-at32ap/at32ap700x.c
@@ -1055,8 +1055,6 @@ struct platform_device *__init at32_add_device_usart(unsigned int id)
 	return at32_usarts[id];
 }
 
-struct platform_device *atmel_default_console_device;
-
 void __init at32_setup_serial_console(unsigned int usart_id)
 {
 	atmel_default_console_device = at32_usarts[usart_id];
I doubt this assignment will work if you remove the struct above. I did not
look at how AT91 does this, will it be similar affected?
none the still exist in the kernel, its just moved

Best Regards,
J.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help