Thread (36 messages) 36 messages, 7 authors, 2011-12-07

[RFC PATCH 2/3] pinctrl: imx: add pinmux-imx53 support

flat view

From: Uwe Kleine-König <hidden>
Date: 2011-12-06 08:05:51
Also in: lkml

Hi,

On Tue, Dec 06, 2011 at 08:33:28AM +0100, Lothar Wa?mann wrote:
Shawn Guo writes:
quoted
On Mon, Dec 05, 2011 at 10:18:38PM +0100, Sascha Hauer wrote:
quoted
Freescale has named the pins after their primary function which is quite
confusing.

The above means:

MX53_PATA_DATA8 -> mux mode 4
MX53_PATA_DATA9 -> mux mode 4
...

This brings me to the point that currently we have the pins described as

#define MX53_PAD_<name>__<function>
But that's also the reason why we have so many lengthy iomux-mx*.h on
imx.  Taking iomux-mx53.h for example, it's a 109K header with 1219
LOC, but probably only 10% of the definitions will actually be used.
Which has the benefit of having correct pin definitions for everyone
to use. If developers who need to use currently unused pindefs have to
create them on their own, there will always be a good chance in
getting them wrong.
Another upside is, that adding the complete list once doesn't result in
conflicts if two people add new definitions in the same timeframe. As
the header are only cpp symbols that don't hurt at runtime I think
having them complete is better than the incremental approach.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help