Thread (51 messages) 51 messages, 8 authors, 2011-08-25

[PATCH 2/6] ARM: add Highbank core platform support

flat view
STALE5525d

From: Jamie Iles <hidden>
Date: 2011-08-16 22:19:45

Revision v1 of 27 in this series.

Revisions (27)
  1. v1
  2. v1 current
  3. v1
  4. v1
  5. v1
  6. v1
  7. v1
  8. v1
  9. v1
  10. v1
  11. v1
  12. v1
  13. v1
  14. v1
  15. v1
  16. v1
  17. v1
  18. v1
  19. v1
  20. v1
  21. v1
  22. v1
  23. v1
  24. v1
  25. v1
  26. v1
  27. v2 [diff vs current] 
Hi Rob,

On Tue, Aug 16, 2011 at 03:34:54PM -0500, Rob Herring wrote:
From: Rob Herring <redacted>

This adds basic support for the Calxeda Highbank platform.

Signed-off-by: Rob Herring <redacted>
---
[...]
quoted hunk ↗ jump to hunk
+static void __init highbank_timer_init(void)
+{
+	int irq;
+	struct device_node *np;
+	void __iomem *timer_base;
+
+	/* Map system registers */
+	np = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs");
+	sregs_base = of_iomap(np, 0);
Should the return values be checked here?  I know that all valid device trees 
should have these nodes and valid a reg property, but I don't know if the 
error handling needs to be a bit more explicit.  For my platform I have put 
these checks and panics() if they fail, but I'm not sure if that's the right 
thing!

Jamie
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help