Thread (65 messages) flat view 65 messages, 10 authors, 2011-07-19
STALE5541d

[PATCH 10/17] mach-ebsa110: retire custom LED code

From: Russell King - ARM Linux <hidden>
Date: 2011-07-10 09:36:16

On Wed, Jul 06, 2011 at 08:34:40PM +0800, Bryan Wu wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 066009a..2a37079 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -350,6 +350,10 @@ config ARCH_EBSA110
 	select ISA
 	select NO_IOPORT
 	select ARCH_USES_GETTIMEOFFSET
+	select NEW_LEDS
+	select LEDS_CLASS
+	select LEDS_TRIGGERS
+	select LEDS_TRIGGER_HEARTBEAT
Same comment about forcing.
-static int __init leds_init(void)
+static int __init ebsa110_leds_init(void)
 {
-	if (machine_is_ebsa110())
-		leds_event = ebsa110_leds_event;
+
+	struct led_classdev *cdev;
+	int ret;
Same comment about initialization.  This seems to be a common theme.

As a whole, this patch set seems to result in a net step backwards to
the goal of a single kernel image.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help