Thread (65 messages) flat view 65 messages, 10 authors, 2011-07-19
STALE5538d

Revision v1 of 2 in this series.

Revisions (2)
  1. v1 [diff vs current]
  2. v1 current

[PATCH 00/17] Introduce a led trigger for CPU activity

From: Eric Miao <hidden>
Date: 2011-07-06 13:19:43

On Wed, Jul 6, 2011 at 9:16 PM, Russell King - ARM Linux
[off-list ref] wrote:
On Wed, Jul 06, 2011 at 09:13:14PM +0800, Eric Miao wrote:
quoted
quoted
?drivers/leds/ledtrig-cpu.c ? ? ? ? ? ? ? ? ? ? | ?144 ++++++++++++
?include/linux/leds.h ? ? ? ? ? ? ? ? ? ? ? ? ? | ? 15 ++
?105 files changed, 1532 insertions(+), 3119 deletions(-)
Not bad, I like the numbers here. This is definitely a good move.
I had long ago wanted to remove those legacy LED code in mach-pxa.
The down-side is that through these moves we've lost functionality each
time. ?For example, the blinking heartbeat LED on the Assabet and
Netwinder which I always enabled to let me know whether the machines
were still alove has long since gone.

I hope that this series restores that functionality on those platforms
where it has been lost.
Yeah, I have the same concern. So probably extending the current simple
API to allow a more flexible behavior would be better.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help