On Wed, 6 Jul 2011, Russell King - ARM Linux wrote:
On Wed, Jul 06, 2011 at 09:13:14PM +0800, Eric Miao wrote:
quoted
quoted
?drivers/leds/ledtrig-cpu.c ? ? ? ? ? ? ? ? ? ? | ?144 ++++++++++++
?include/linux/leds.h ? ? ? ? ? ? ? ? ? ? ? ? ? | ? 15 ++
?105 files changed, 1532 insertions(+), 3119 deletions(-)
Not bad, I like the numbers here. This is definitely a good move.
I had long ago wanted to remove those legacy LED code in mach-pxa.
The down-side is that through these moves we've lost functionality each
time. For example, the blinking heartbeat LED on the Assabet and
Netwinder which I always enabled to let me know whether the machines
were still alove has long since gone.
There exists a generic heartbeat LED trigger for that. Making it the
default for a particular LED should be trivial.
Nicolas