Thread (59 messages) flat view 59 messages, 6 authors, 2011-03-21

[PATCH v4 16/19] ARM: LPAE: Use generic dma_addr_t type definition

From: Russell King - ARM Linux <hidden>
Date: 2011-02-15 14:30:07
Also in: lkml

On Mon, Feb 14, 2011 at 01:01:30PM +0000, Catalin Marinas wrote:
Maybe we could make the dma_addr_t size configurable (and disabled by
default) since I expect there'll be platforms capable of >32-bit DMA.
It would be far better to fix the dma_addr_t abuses.  I've already fixed
those in the pl08x driver:

struct lli {
        dma_addr_t src;
        dma_addr_t dst;
        dma_addr_t next;
        u32 cctl;
};

became:

struct pl08x_lli {
        u32 src;
        u32 dst;
        u32 lli;
        u32 cctl;
};

and similar needs to be done elsewhere in ARM specific drivers.
dma_addr_t has no business being in structures that describe data which
hardware accesses.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help