Thread (59 messages) 59 messages, 6 authors, 2011-03-21

[PATCH v4 17/19] ARM: LPAE: mark memory banks with start > ULONG_MAX as highmem

flat view

From: Russell King - ARM Linux <hidden>
Date: 2011-02-12 10:37:06
Also in: lkml

On Mon, Jan 24, 2011 at 05:55:59PM +0000, Catalin Marinas wrote:
quoted hunk ↗ jump to hunk
@@ -782,7 +782,8 @@ static void __init sanity_check_meminfo(void)
 
 #ifdef CONFIG_HIGHMEM
 		if (__va(bank->start) > vmalloc_min ||
-		    __va(bank->start) < (void *)PAGE_OFFSET)
+		    __va(bank->start) < (void *)PAGE_OFFSET ||
+		    bank->start > ULONG_MAX)
I think this check should be first, so that we don't try to evaluate __va()
on phys addresses > ULONG_MAX, possibly resulting in truncation.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help