[PATCH] omap4: Fix ULPI PHY init for ES1.0 SDP (Re: 4430SDP boot failure)

* Russell King - ARM Linux [off-list ref] [110113 01:15]:

On Thu, Jan 13, 2011 at 02:22:06PM +0530, Anand Gadiyar wrote:

quoted

Tony Lindgren wrote:

quoted

 	/* Power on the ULPI PHY */
-	if (gpio_is_valid(OMAP4SDP_MDM_PWR_EN_GPIO)) {
-		/* FIXME: Assumes pad is already muxed for GPIO mode */
-		gpio_request(OMAP4SDP_MDM_PWR_EN_GPIO, "USBB1 PHY

VMDM_3V3");

quoted

+	status = gpio_request(OMAP4SDP_MDM_PWR_EN_GPIO, "USBB1 PHY

VMDM_3V3");

quoted

+	if (status)
+		pr_err("%s: Could not get USBB1 PHY GPIO\n");

Tony,

This throws up a build warning as there's no parameter corresponding to
the %s. Showed up in linux-next as of today.

Oops, sorry, will fix.
 

It's pretty obvious that the above is wrong, and the compiler would
have caught it with a warning when building it.  Was the above patch
not build-tested before it was committed?

Sure, boot tested it but missed the warning though.
 

Given the very sorry state of OMAP in mainline at present, I'm surprised
that this kind of stuff is still going on...

At least I boot test the patches I send..

Regards,

Tony