[PATCH v4 07/10] ARM: mx28: add the second fec device registration
From: s.hauer@pengutronix.de (Sascha Hauer)
Date: 2011-01-11 10:29:09
Also in:
netdev
On Thu, Jan 06, 2011 at 03:13:15PM +0800, Shawn Guo wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Shawn Guo <redacted> --- arch/arm/mach-mxs/mach-mx28evk.c | 28 +++++++++++++++++++++++++--- 1 files changed, 25 insertions(+), 3 deletions(-) static void __init mx28evk_init(void)@@ -117,7 +136,10 @@ static void __init mx28evk_init(void) mx28_add_duart(); mx28evk_fec_reset(); - mx28_add_fec(0, &mx28_fec_pdata); + mx28_add_fec(0, &mx28_fec_pdata[0]); +#ifdef CONFIG_FEC2 + mx28_add_fec(1, &mx28_fec_pdata[1]); +#endif
Please don't do this. If you really want to make this configurable with kconfig use a board specific option, not a driver specific option. I think this should be made unconditional though. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |