[PATCH 52/74] ST SPEAr13xx: Adding CPU hotplug support added for SMP platforms

Hello Sundar,

Sorry for replying so late :).

On 9/3/2010 11:30 AM, Sundar wrote:

Hi,

On Mon, Aug 30, 2010 at 4:09 PM, Viresh KUMAR [off-list ref] wrote:

quoted

From: Deepak Sikri <redacted>

Signed-off-by: Deepak Sikri <redacted>
Signed-off-by: shiraz hashim <redacted>
Signed-off-by: Viresh Kumar <redacted>
---

quoted

+       flush_cache_all();
+       asm volatile(
+       "       mcr     p15, 0, %1, c7, c5, 0\n"
+       "       mcr     p15, 0, %1, c7, c10, 4\n"

Isnt this a Cortex-A9 platform? If yes, then this is not implemented
on the Cortex-A9 if I am right.
You should use a dsb() here.

yes, I would place dsb here.

quoted

+               /*
+                * here's the WFI
+                */
+               asm(".word      0xe320f003\n"
+                   :

Also, why not a simple asm volatile("wfi" : : : "memory"); instead of
hard coded values.

Would add a wfi() macro in asm/system.h including sev() as suggested by
Russell. This statement would be replaced by a simple wfi().

regards
Shiraz