[PATCH 03/74] ST SPEAr: Formalized timer support

On 09:34 Mon 13 Sep     , Shiraz Hashim wrote:

Dear Jean,

On 9/13/2010 9:07 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:

quoted

On 08:52 Mon 13 Sep     , Shiraz Hashim wrote:

quoted

Dear Jean,

On 9/7/2010 4:25 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:

quoted

quoted

 
-#endif
+static void __init spear3xx_timer_init(void)
+{
+	spear_setup_timer();

why not call it directly?

A single level of abstraction was provided so that if archs (spear3xx/6xx/13xx)
required to do something extra.

it does not seems to be needed at all so for now call it directly is enough

OK. So, I think what could be better is to set the parent clock of the gpt in
the arch specific function like spear3xx_timer_init. This would also remove this
part from the timer code.

ok

Best Regards,
J.