Kernel related (?) user space crash at ARM11 MPCore
From: Russell King - ARM Linux <hidden>
Date: 2009-10-25 14:48:05
Possibly related (same subject, not in this thread)
- 2009-09-07 · Kernel related (?) user space crash at ARM11 MPCore · catalin.marinas@arm.com (Catalin Marinas)
- 2009-09-07 · Kernel related (?) user space crash at ARM11 MPCore · Mikael Pettersson <hidden>
- 2009-09-07 · Kernel related (?) user space crash at ARM11 MPCore · catalin.marinas@arm.com (Catalin Marinas)
- 2009-09-07 · Kernel related (?) user space crash at ARM11 MPCore · Dirk Behme <hidden>
- 2009-09-07 · Kernel related (?) user space crash at ARM11 MPCore · catalin.marinas@arm.com (Catalin Marinas)
On Tue, Oct 20, 2009 at 12:39:08PM +0100, Catalin Marinas wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/mm/fault-armv.c b/arch/arm/mm/fault-armv.c index d0d17b6..4e37ab6 100644 --- a/arch/arm/mm/fault-armv.c +++ b/arch/arm/mm/fault-armv.c@@ -160,8 +160,7 @@ void update_mmu_cache(struct vm_area_struct *vma, unsigned long addr, pte_t pte) if (mapping) { if (cache_is_vivt()) make_coherent(mapping, vma, addr, pfn); - else if (vma->vm_flags & VM_EXEC) - __flush_icache_all(); + __flush_icache_all();
BTW, why are you penalising VIVT cached systems as well with this change? Surely you meant to leave the 'else' still there.