Re: [PATCH v2 04/31] arm64: MMU definitions

On Wed, Aug 15, 2012 at 3:30 PM, Arnd Bergmann [off-list ref] wrote:

quoted

+#define TCR_IPS_40BIT                (2 << 32)

By default, constants are int, i.e. 32-bit. So you must write

2ULL << 32

quoted

+#define TCR_ASID16           (1 << 36)

1ULL

As a matter of coding style, I would much prefer tables like this to be
written as

#define TCR_IRGN_MASK           0x0000000003000300

0x0000000003000300ULL, to be safe

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds