Thread (154 messages) 154 messages, 12 authors, 2023-03-20

Re: [PATCH v7 30/41] x86/shstk: Handle thread shadow stack

From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Date: 2023-03-09 17:05:20
Also in: linux-arch, linux-doc, linux-mm, lkml

On Thu, 2023-03-09 at 15:12 +0100, Borislav Petkov wrote:
On Wed, Mar 08, 2023 at 08:03:17PM +0000, Edgecombe, Rick P wrote:

Btw,

pls try to trim your replies as I need ot scroll through pages of
quoted
text to find the response.
Sure sorry.


[...]
quoted
If the default SSP value logic is too hidden, what about some
clearer
code and comments, like this?
The problem with this function is that it needs to return three
things:

* success:
 ** 0
 or
 ** shadow stack address
* failure: due to allocation.

How about this below instead? (totally untested ofc):
Ah, I see what you were saying now. It looks like it will work to me if
you think it is better stylistically.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help