Re: [PATCH v7 21/41] mm: Add guard pages around a shadow stack.
From: Borislav Petkov <bp@alien8.de>
Date: 2023-03-07 10:33:50
Also in:
linux-arch, linux-doc, linux-mm, lkml
On Tue, Mar 07, 2023 at 01:29:50AM +0000, Edgecombe, Rick P wrote:
On Mon, 2023-03-06 at 09:08 +0100, Borislav Petkov wrote:quoted
Just typos:All seem reasonable to me. Thanks. For using the log verbiage for the comment, it is quite big. Does something like this seem reasonable?
Yeah, it does. I wouldn't want to lose that explanation in a commit
message.
However, this special aspect pertains to the shstk implementation in x86
but the code is generic mm and such arch-specific comments are kinda
unfitting there.
I wonder if it would be better if you could stick that explanation
somewhere in arch/x86/ and only refer to it in a short comment above
VM_SHADOW_STACK check in stack_guard_start_gap()...
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette