Thread (222 messages) 222 messages, 21 authors, 2022-11-03

Re: [PATCH v2 17/39] mm: Fixup places that call pte_mkwrite() directly

From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Date: 2022-10-04 16:16:09
Also in: linux-arch, linux-doc, linux-mm, lkml

On Tue, 2022-10-04 at 02:56 +0300, Kirill A . Shutemov wrote:
On Thu, Sep 29, 2022 at 03:29:14PM -0700, Rick Edgecombe wrote:
quoted
From: Yu-cheng Yu <redacted>

With the introduction of shadow stack memory there are two ways a
pte can
be writable: regular writable memory and shadow stack memory.

In past patches, maybe_mkwrite() has been updated to apply
pte_mkwrite()
or pte_mkwrite_shstk() depending on the VMA flag. This covers most
cases
where a PTE is made writable. However, there are places where
pte_mkwrite()
is called directly and the logic should now also create a shadow
stack PTE
in the case of a shadow stack VMA.

  - do_anonymous_page() and migrate_vma_insert_page() check
VM_WRITE
    directly and call pte_mkwrite(), which is the same as
maybe_mkwrite()
    in logic and intention. Just change them to maybe_mkwrite().
Looks like you folded change for do_anonymous_page() into the wrong
patch.
I see the relevant change in the previous patch.
Arg, yep thanks. It got moved accidentally.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help