RE: [PATCH 1/7] clk: renesas: r8a77990: Add DAB clock

Hi Geert,

From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Sent: 01 March 2021 14:47
Subject: RE: [PATCH 1/7] clk: renesas: r8a77990: Add DAB clock

Hi Geert,

Thanks for your feedback!

quoted

From: Geert Uytterhoeven <geert@linux-m68k.org>
Sent: 26 February 2021 08:35
Subject: Re: [PATCH 1/7] clk: renesas: r8a77990: Add DAB clock

Hi Fabrizio,

On Thu, Feb 25, 2021 at 11:52 PM Fabrizio Castro
[off-list ref] wrote:

quoted

This patch adds the DAB clock to the R8A77990 SoC.

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Thanks for your patch!

quoted

--- a/drivers/clk/renesas/r8a77990-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a77990-cpg-mssr.c

@@ -232,6 +232,7 @@ static const struct mssr_mod_clk

r8a77990_mod_clks[]

quoted

__initconst = {

quoted

        DEF_MOD("ssi2",                 1013,   MOD_CLK_ID(1005)),
        DEF_MOD("ssi1",                 1014,   MOD_CLK_ID(1005)),
        DEF_MOD("ssi0",                 1015,   MOD_CLK_ID(1005)),
+       DEF_MOD("dab",                  1016,   R8A77990_CLK_S3D1),

Unfortunately this bit is not documented in the R-Car Gen3 Hardware
User's Manual, so I have to trust you on this.

Yeah, unfortunately there is no official document with this information
as of yet.

I think this patch is worth taking.

Thanks,
Fab

Cheers,
Fab

quoted

quoted

        DEF_MOD("scu-all",              1017,   R8A77990_CLK_S3D4),
        DEF_MOD("scu-dvc1",             1018,   MOD_CLK_ID(1017)),
        DEF_MOD("scu-dvc0",             1019,   MOD_CLK_ID(1017)),

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
m68k.org

In personal conversations with technical people, I call myself a hacker.
But
when I'm talking to journalists I just say "programmer" or something

like

quoted

that.
                                -- Linus Torvalds