Re: [PATCH 5/7] arm64: dts: renesas: r8a77990: Add DAB support
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2021-02-26 12:48:49
Also in:
linux-arm-kernel, linux-devicetree, linux-renesas-soc, lkml
Hi Fabrizio, Thank you for the patch. On Thu, Feb 25, 2021 at 10:51:45PM +0000, Fabrizio Castro wrote:
quoted hunk ↗ jump to hunk
R-Car E3 (a.k.a. r8a77990) comes with the DAB hardware accelerator. This patch adds SoC specific support. Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> --- arch/arm64/boot/dts/renesas/r8a77990.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index 5010f23fafcc..5a6b835f137a 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi@@ -963,6 +963,18 @@ ipmmu_vp0: iommu@fe990000 { #iommu-cells = <1>; }; + dab: dab@e6730000 { + compatible = "renesas,dab-r8a77990", + "renesas,rcar-gen3-dab"; + reg = <0x00 0xe6730000 0x00 0x120>;
We often express the first cell as just 0. reg = <0 0xe6730000 0 0x120>;
+ interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 1016>;
As the clock isn't documented in the documentation, I can't verify this of the resets property :-S
+ clock-names = "dab";
I'll comment on the clock name in the DT bindings. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+ power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+ resets = <&cpg 1016>;
+ status = "disabled";
+ };
+
avb: ethernet@e6800000 {
compatible = "renesas,etheravb-r8a77990",
"renesas,etheravb-rcar-gen3";-- Regards, Laurent Pinchart