Hello Sergei,

Thanks for your feedback!

From: Sergei Shtylyov <redacted>
Sent: 26 February 2021 09:07
Subject: Re: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB

Hello!

On 26.02.2021 1:51, Fabrizio Castro wrote:

quoted

Document bindings for R-Car DAB hardware accelerator, currently
found on the r8a77990 SoC (a.k.a. R-Car E3) and on the r8a77965
SoC (a.k.a. R-Car M3-N).

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
  .../devicetree/bindings/misc/renesas,dab.yaml | 75 +++++++++++++++++++
  1 file changed, 75 insertions(+)
  create mode 100644

Documentation/devicetree/bindings/misc/renesas,dab.yaml

quoted

diff --git a/Documentation/devicetree/bindings/misc/renesas,dab.yaml

b/Documentation/devicetree/bindings/misc/renesas,dab.yaml

quoted

new file mode 100644
index 000000000000..e9494add13d7

--- /dev/null
+++ b/Documentation/devicetree/bindings/misc/renesas,dab.yaml

@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) 2021 Renesas Electronics Corporation
+%YAML 1.2
+---
+$id:

https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetre
e.org%2Fschemas%2Fmisc%2Frenesas%2Cdab.yaml%23&data=04%7C01%7Cfabrizio
.castro.jz%40renesas.com%7C4ea11a8f46fc4f4642ad08d8da35d682%7C53d82571da19
47e49cb4625a166a4a2a%7C0%7C0%7C637499272091083125%7CUnknown%7CTWFpbGZsb3d8
eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&
amp;sdata=p5MNncCLOIMaYLyBtmOl%2Br%2BIKe9ByUqxv1k05FbYj94%3D&reserved=
0

quoted

+$schema:

https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetre
e.org%2Fmeta-
schemas%2Fcore.yaml%23&data=04%7C01%7Cfabrizio.castro.jz%40renesas.com
%7C4ea11a8f46fc4f4642ad08d8da35d682%7C53d82571da1947e49cb4625a166a4a2a%7C0
%7C0%7C637499272091083125%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ
IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=dBI8WMPjxAEvhY
3cj7WKJW4FjCrfN5JpAoqC9XSPNaY%3D&reserved=0

quoted

+
+title: Renesas R-Car DAB Hardware Accelerator
+
+maintainers:
+  - Fabrizio Castro [off-list ref]
+
+description:
+  The DAB hardware accelerator found on some R-Car devices is a

hardware

quoted

+  accelerator for software DAB demodulators.
+  It consists of one FFT (Fast Fourier Transform) module and one

decoder module,

quoted

+  compatible with DAB specification (ETSI EN 300 401 and ETSI TS 102

563).

quoted

+  The decoder module can perform FIC decoding and MSC decoding

processing from

quoted

+  de-puncture to final decoded result.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - renesas,dab-r8a77965     # R-Car M3-N
+          - renesas,dab-r8a77990     # R-Car E3

    Why not renesas,<soc>-dab?

Will change.


Thanks,
Fab

quoted

+      - const: renesas,rcar-gen3-dab # Generic fallback for R-Car Gen3

devices
[...]

MBR, Sergei