Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

From
Jann Horn <jannh@google.com>
Date
2020-05-30 03:17:58
Also in
lkml
Reply to
Kees Cook, 2020-05-30
On Sat, May 30, 2020 at 4:43 AM Kees Cook [off-list ref] wrote:
I mean, yes, that's certainly better, but it just seems a shame that
everyone has to do the get_unused/put_unused dance just because of how
SCM_RIGHTS does this weird put_user() in the middle.

Can anyone clarify the expected failure mode from SCM_RIGHTS? Can we
move the put_user() after instead?
Honestly, I think trying to remove file descriptors and such after
-EFAULT is a waste of time. If userspace runs into -EFAULT, userspace
is beyond saving and can't really do much other than exit immediately.
There are a bunch of places that will change state and then throw
-EFAULT at the end if userspace supplied an invalid address, because
trying to hold locks across userspace accesses just in case userspace
supplied a bogus address is kinda silly (and often borderline
impossible).

You can actually see that even scm_detach_fds() currently just
silently swallows errors if writing some header fields fails at the
end.
Thread (35 messages) 35 messages, 6 authors, last reply 2020-06-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help