Re: [PATCH v2 3/3] selftests/seccomp: Test SECCOMP_IOCTL_NOTIF_ADDFD
From: Tycho Andersen <hidden>
Date: 2020-05-29 13:29:37
Also in:
lkml
From: Tycho Andersen <hidden>
Date: 2020-05-29 13:29:37
Also in:
lkml
On Fri, May 29, 2020 at 12:41:51AM -0700, Kees Cook wrote:
On Thu, May 28, 2020 at 04:08:58AM -0700, Sargun Dhillon wrote:quoted
+ EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0); + + nextid = req.id + 1; + + /* Wait for getppid to be called for the second time */ + sleep(1);I always rebel at finding "sleep" in tests. ;) Is this needed? IIUC, userspace will immediately see EINPROGRESS after the NOTIF_SEND finishes, yes?
Yes, I think we can just drop this, and I agree it's a good idea to do so :) Tycho