Re: [PATCH v2 1/3] seccomp: Add find_notification helper

From
Sargun Dhillon <hidden>
Date
2020-05-29 17:40:43
Also in
lkml
Reply to
Kees Cook, 2020-05-29
While the comment is good, let's actually enforce this with:

if (WARN_ON(!mutex_is_locked(&filter->notif_lock)))
	return NULL;
I don't see much use of lockdep in seccomp (well, any), but
wouldn't a stronger statement be to use lockdep, and just have:

lockdep_assert_held(&filter->notify_lock);

As that checks that the lock is held by the current task.
Although, that does put this check behind lockdep, which means
that running in "normal" circumstances is less safe (but faster?).
Thread (35 messages) 35 messages, 6 authors, last reply 2020-06-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help