Re: [PATCH v4 13/16] fs-verity: support builtin file signatures

On Sat, Jun 15, 2019 at 11:21:43AM -0400, Theodore Ts'o wrote:

On Thu, Jun 06, 2019 at 08:52:02AM -0700, Eric Biggers wrote:

quoted

From: Eric Biggers <redacted>

To meet some users' needs, add optional support for having fs-verity
handle a portion of the authentication policy in the kernel.  An
".fs-verity" keyring is created to which X.509 certificates can be
added; then a sysctl 'fs.verity.require_signatures' can be set to cause
the kernel to enforce that all fs-verity files contain a signature of
their file measurement by a key in this keyring.

I think it might be a good idea to allow the require_signatures
setting to be set on a per-file system basis, via a mount option?  We
could plumb it in via a flag in fsverity_info, set by the file system.

Perhaps, but this is something that can be added later, so I think we should
hold off on it until someone needs it.

Other than this feature request, looks good; you can add:

Reviewed-off-by: Theodore Ts'o [off-list ref]

I assume you mean "Reviewed-by" :-)

- Eric