Thread (89 messages) 89 messages, 6 authors, 2019-01-25

Re: [PATCH v6 11/16] sched/fair: Add uclamp support to energy_compute()

From: Quentin Perret <hidden>
Date: 2019-01-22 15:14:14
Also in: linux-pm, lkml

On Tuesday 22 Jan 2019 at 15:01:37 (+0000), Patrick Bellasi wrote:
quoted
I'm not saying it's useful, I'm saying userspace can decide to do that
if it thinks it is a good idea. The default should be min_cap = 1024 for
RT, no questions. But you _can_ change it at runtime if you want to.
That's my point. And doing that basically provides the same behaviour as
what we have right now in terms of EAS calculation (but it changes the
freq selection obviously) which is why I'm not fundamentally opposed to
your patch.
Well, I think it's tricky to say whether the current or new approach
is better... it probably depends on the use-case.
Agreed.
quoted
So in short, I'm fine with the behavioural change, but please at least
mention it somewhere :-)
Anyway... agree, it's just that to add some documentation I need to
get what you are pointing out ;)

Will come up with some additional text to be added to the changelog
Sounds good.
Maybe we can add a more detailed explanation of the different
behaviors you can get in the EAS documentation which is coming to
mainline ?
Yeah, if you feel like it, I guess that won't hurt :-)

Thanks,
Quentin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help