Re: [RFC PATCH v2 25/27] x86/cet: Add PTRACE interface for CET
From: Ingo Molnar <mingo@kernel.org>
Date: 2018-07-12 14:03:35
Also in:
linux-arch, linux-doc, linux-mm, lkml
From: Ingo Molnar <mingo@kernel.org>
Date: 2018-07-12 14:03:35
Also in:
linux-arch, linux-doc, linux-mm, lkml
* Yu-cheng Yu [off-list ref] wrote:
quoted
quoted
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c index e2ee403865eb..ac2bc3a18427 100644 --- a/arch/x86/kernel/ptrace.c +++ b/arch/x86/kernel/ptrace.c@@ -49,7 +49,9 @@ enum x86_regset {REGSET_IOPERM64 = REGSET_XFP, REGSET_XSTATE, REGSET_TLS, + REGSET_CET64 = REGSET_TLS, REGSET_IOPERM32, + REGSET_CET32, };Why does REGSET_CET64 alias on REGSET_TLS?In x86_64_regsets[], there is no [REGSET_TLS]. The core dump code cannot handle holes in the array.
Is there a fundamental (ABI) reason for that?
quoted
to "CET" (which is a well-known acronym for "Central European Time"), not to CFE?I don't know if I can change that, will find out.
So what I'd suggest is something pretty simple: to use CFT/cft in kernel internal names, except for the Intel feature bit and any MSR enumeration which can be CET if Intel named it that way, and a short comment explaining the acronym difference. Or something like that. Thanks, Ingo