Re: [RFC] vfs: skip extra attributes check on removal for symlinks

From
Al Viro <viro@ZenIV.linux.org.uk>
Date
2018-05-10 20:48:13
Also in
linux-fsdevel, linux-xfs, lkml
Reply to
Luis R. Rodriguez, 2018-04-26
On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wrote:
Since we cannot set these attributes we should special-case the
immutable/append on delete for symlinks, this would be consistent with
what we *do* allow on Linux for all filesystems.
Er...  So why not simply sanity-check it in places that set it on
inodes?  If anything, I would suggest
	* converting all places that set those in ->i_flags to
inode_set_flags()
	* making inode_set_flags() check and return an error on
that...
Thread (11 messages) 11 messages, 3 authors, last reply 2018-05-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help