Re: [RFC] vfs: skip extra attributes check on removal for symlinks

From
Al Viro <viro@ZenIV.linux.org.uk>
Date
2018-05-11 02:42:39
Also in
linux-fsdevel, linux-xfs, lkml
Reply to
Luis R. Rodriguez, 2018-05-10
On Thu, May 10, 2018 at 11:05:51PM +0000, Luis R. Rodriguez wrote:
On Thu, May 10, 2018 at 09:48:07PM +0100, Al Viro wrote:
quoted
On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wrote:
quoted
Since we cannot set these attributes we should special-case the
immutable/append on delete for symlinks, this would be consistent with
what we *do* allow on Linux for all filesystems.
Er...  So why not simply sanity-check it in places that set it on
inodes? 
The patch is not about sanity-checks on setters though as *that* is in place
already. Its about the case where the filesystem gets corrupted and the VFS
*still* does process these attributes for symlinks and still prevents
deletion because of these attributes.
... and this corrupted fs ends up setting those flags on in-core inodes.
Which is where we ought to block that.  Seriously, let's make sure that
->i_flags manipulations are done by inode_set_flags() (e.g. btrfs open-codes
that, apparently) and let's make _that_ check and reject those.
Thread (11 messages) 11 messages, 3 authors, last reply 2018-05-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help