Re: [RFC] vfs: skip extra attributes check on removal for symlinks

From
Luis R. Rodriguez <mcgrof@kernel.org>
Date
2018-05-10 23:05:53
Also in
linux-fsdevel, linux-xfs, lkml
Reply to
Al Viro, 2018-05-10
On Thu, May 10, 2018 at 09:48:07PM +0100, Al Viro wrote:
On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wrote:
quoted
Since we cannot set these attributes we should special-case the
immutable/append on delete for symlinks, this would be consistent with
what we *do* allow on Linux for all filesystems.
Er...  So why not simply sanity-check it in places that set it on
inodes? 
The patch is not about sanity-checks on setters though as *that* is in place
already. Its about the case where the filesystem gets corrupted and the VFS
*still* does process these attributes for symlinks and still prevents
deletion because of these attributes.

So we already do not allow for settings these attributes.
If anything, I would suggest
	* converting all places that set those in ->i_flags to
inode_set_flags()
	* making inode_set_flags() check and return an error on
that...
But if I misunderstood your suggestion please let me know. I'll send out
a v2 RFC next which illustrates what filesystems can do for now.

  Luis
Thread (11 messages) 11 messages, 3 authors, last reply 2018-05-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help