Re: [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

+/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */

I don't think this comment is very useful.

+static inline u16 ki_hint_valid(enum rw_hint hint)

I'd call this ki_hint_validate.

+{
+	if (hint > MAX_KI_HINT)
+		return 0;
+
+	return hint;

Nit: kill the empty line.

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>