Re: [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

On 5/18/18 9:05 AM, Christoph Hellwig wrote:

quoted

+/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */

I don't think this comment is very useful.

quoted

+static inline u16 ki_hint_valid(enum rw_hint hint)

I'd call this ki_hint_validate.

quoted

+{
+	if (hint > MAX_KI_HINT)
+		return 0;
+
+	return hint;

Nit: kill the empty line.

I'll clean this up in the next revision.